fix(security): fix login AND logic to OR, add signup input validation, separate OTP rate limit keys

This commit is contained in:
Hamza-Ayed
2026-06-17 07:05:58 +03:00
parent 70c06edd71
commit 1a9619f9f8
3 changed files with 38 additions and 7 deletions

View File

@@ -6,8 +6,23 @@ $email = filterRequest('email');
$phone = filterRequest('phone');
$password = filterRequest('password');
// Hash the password
$hashed_password = password_hash($password, PASSWORD_DEFAULT);
if (empty($phone) && empty($email)) {
echo json_encode(["status" => "Failure", "data" => "Phone or email is required."]);
exit;
}
// Build WHERE dynamically: support phone-only, email-only, or both
$conditions = [];
$params = [':password' => $password];
if (!empty($phone)) {
$conditions[] = "passengers.phone = :phone";
$params[':phone'] = $phone;
}
if (!empty($email)) {
$conditions[] = "passengers.email = :email";
$params[':email'] = $email;
}
$where = implode(' OR ', $conditions);
$sql = "SELECT
passengers.`id`,
@@ -29,11 +44,9 @@ FROM
`passengers`
LEFT JOIN email_verifications ON email_verifications.email = passengers.email
WHERE
passengers.phone = :phone AND passengers.email = :email ";
$where";
$stmt = $con->prepare($sql);
$stmt->bindParam(':email', $email);
$stmt->bindParam(':phone', $phone);
$stmt->execute();
$stmt->execute($params);
$data = $stmt->fetchAll(PDO::FETCH_ASSOC);
$count = $stmt->rowCount();