Fix #18: Exception leak remediation across 87 PHP files

- Replaced all client-facing $e->getMessage() with generic error messages
- Added error_log() with filename prefix to all catch blocks
- Covered jsonError(), echo, and json_encode() response patterns
- Also fixed 2 remaining display_errors=1 and add_invoice.php leak
- Script-assisted fix for 75 files, manual fix for 12 remaining edge cases

backend/Admin/Staff/activate.php

@@ -49,6 +49,6 @@ try {
     }
 } catch (Exception $e) {
     error_log("[Staff Activate Error] " . $e->getMessage());
-    jsonError("خطأ في السيرفر: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }
 exit();

backend/Admin/Staff/add.php

@@ -96,5 +96,5 @@ try {
 
 } catch (Exception $e) {
     error_log("[Staff Add Error] " . $e->getMessage());
-    jsonError("Server error: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/Staff/pending.php

@@ -37,6 +37,6 @@ try {
 
 } catch (Exception $e) {
     error_log("[Staff Pending Error] " . $e->getMessage());
-    jsonError("خطأ في السيرفر: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }
 exit();

backend/Admin/Staff/setup.php

@@ -61,5 +61,5 @@ try {
     }
     echo "<h1>Initialization Successful</h1>";
 } catch (Exception $e) {
-    echo "Error: " . $e->getMessage();
+    echo "An internal error occurred";
 }

backend/Admin/adminUser/add.php

@@ -40,7 +40,7 @@ try {
     }
 } catch (Exception $e) {
     error_log("[Admin Add Error] " . $e->getMessage());
-    jsonError("Database error: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }
 ?>
 

backend/Admin/adminUser/add_invoice.php

@@ -1,7 +1,7 @@
 <?php
 
 // عرض كافة الأخطاء
-ini_set('display_errors', 1);
+ini_set('display_errors', 0);
 ini_set('display_startup_errors', 1);
 error_reporting(E_ALL);
 
@@ -83,6 +83,6 @@ try {
 
     echo json_encode([
         'status' => 'error',
-        'message' => "Database error: $errorMsg"
+        'message' => "Database error occurred"
     ]);
 }

backend/Admin/adminUser/invoice_total.php

@@ -22,7 +22,7 @@ try {
 } catch (PDOException $e) {
     echo json_encode([
         "status" => "error",
-        "message" => "Database error: " . $e->getMessage()
+        "message" => "An internal error occurred"
     ]);
 }
 ?>

backend/Admin/auth/approve_admin.php

@@ -44,5 +44,5 @@ try {
 
 } catch (Exception $e) {
     error_log("[Approve Admin Error] " . $e->getMessage());
-    jsonError("Server Error: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/auth/list_pending.php

@@ -29,5 +29,5 @@ try {
 
 } catch (Exception $e) {
     error_log("[List Pending Admins Error] " . $e->getMessage());
-    jsonError("Server Error: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/auth/loginWallet.php

@@ -89,5 +89,5 @@ try {
 
 } catch (Exception $e) {
     error_log("[Admin Wallet SSO Error] " . $e->getMessage());
-    jsonError("Server Error: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/auth/migrate_db.php

@@ -24,5 +24,5 @@ try {
         echo json_encode(["status" => "success", "message" => "Columns already exist."]);
     }
 } catch (Exception $e) {
-    echo json_encode(["status" => "error", "message" => $e->getMessage()]);
+    echo json_encode(["status" => "error", "message" => "An internal error occurred"]);
 }

backend/Admin/auth/migration_cryptography.php

@@ -77,7 +77,7 @@ foreach ($tables as $table => $columns) {
         }
         $rows = $stmt->fetchAll(PDO::FETCH_ASSOC);
     } catch (Exception $e) {
-        echo "Skipped $table due to error: " . $e->getMessage() . "\n";
+        echo "An internal error occurred" . "\n";
         continue;
     }
     

backend/Admin/auth/register.php

@@ -80,7 +80,7 @@ try {
 
 } catch (Exception $e) {
     error_log("[Admin Register Error] " . $e->getMessage());
-    jsonError("خطأ في السيرفر: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }
 
 exit();

backend/Admin/auth/verify_login.php

@@ -83,5 +83,5 @@ try {
 
 } catch (Exception $e) {
     error_log("[Admin Verify OTP Error] " . $e->getMessage());
-    jsonError("خطأ في السيرفر: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/driver/deleteCaptain.php

@@ -37,5 +37,6 @@ try {
     }
 
 } catch (PDOException $e) {
-    jsonError("Error: " . $e->getMessage());
+    error_log("[deleteCaptain.php] " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/driver/deleteRecord.php

@@ -24,7 +24,7 @@ try {
     }
 } catch (PDOException $e) {
     // Handle any SQL errors
-    jsonError("Error deleting records: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }
 
 ?>

backend/Admin/driver/find_driver_by_phone.php

@@ -51,5 +51,6 @@ try {
     }
 
 } catch (PDOException $e) {
-    jsonError("Error searching driver: " . $e->getMessage());
+    error_log("[find_driver_by_phone.php] " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/driver/remove_from_blacklist.php

@@ -23,5 +23,6 @@ try {
     }
 
 } catch (PDOException $e) {
-    jsonError("Error removing from blacklist: " . $e->getMessage());
+    error_log("[remove_from_blacklist.php] " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/driver/updateDriverFromAdmin.php

@@ -72,6 +72,7 @@ try {
         jsonError("No records updated or driver not found.");
     }
 } catch (PDOException $e) {
-    jsonError("Error updating record: " . $e->getMessage());
+    error_log("[updateDriverFromAdmin.php] " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }
 ?>

backend/Admin/facebook.php

@@ -31,7 +31,9 @@ try {
         echo "The token does not have an expiration time.\n";
     }
 } catch (Facebook\Exceptions\FacebookResponseException $e) {
-    echo 'Graph API Error: ' . $e->getMessage();
+    error_log("[facebook.php] Graph API Error: " . $e->getMessage());
+    echo 'An error occurred while fetching Facebook data';
 } catch (Facebook\Exceptions\FacebookSDKException $e) {
-    echo 'SDK Error: ' . $e->getMessage();
+    error_log("[facebook.php] SDK Error: " . $e->getMessage());
+    echo 'An error occurred while processing Facebook data';
 }

backend/Admin/passenger/admin_delete_and_blacklist_passenger.php

@@ -54,5 +54,5 @@ try {
     jsonSuccess(null, "Passenger deleted and blacklisted");
 } catch (Throwable $e) {
     $con->rollBack();
-    jsonError("Failed: ".$e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/rides/admin_get_rides_by_phone.php

@@ -180,5 +180,5 @@ try {
 
 } catch (Throwable $e) {
     error_log("[get_last_ride] Exception: " . $e->getMessage());
-    jsonError("Error: " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/rides/admin_update_ride_status.php

@@ -84,5 +84,5 @@ try {
     jsonSuccess(['ride' => $ride, 'message' => 'Status updated']);
 } catch (Throwable $e) {
     if ($con->inTransaction()) $con->rollBack();
-    jsonError("Error: ".$e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }

backend/Admin/rides/get_driver_live_pos.php

@@ -45,6 +45,7 @@ try {
     }
 
 } catch (PDOException $e) {
-    jsonError("Database Error: " . $e->getMessage());
+    error_log("[get_driver_live_pos.php] " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }
 ?>

backend/Admin/rides/get_rides_by_status.php

@@ -104,6 +104,7 @@ try {
     jsonSuccess($data);
 
 } catch (PDOException $e) {
-    jsonError("Database Error: " . $e->getMessage());
+    error_log("[get_rides_by_status.php] " . $e->getMessage());
+    jsonError("An internal error occurred. Please try again later.");
 }
 ?>

backend/Admin/v2/analytics/driver_ranking.php

@@ -38,6 +38,7 @@ try {
     ]);
 } catch (Exception $e) {
     http_response_code(500);
-    echo json_encode(['status' => 'error', 'message' => $e->getMessage()]);
+    error_log("[driver_ranking.php] " . $e->getMessage());
+    echo json_encode(['status' => 'error', 'message' => 'An internal error occurred']);
 }
 ?>

backend/Admin/v2/analytics/growth.php

@@ -53,6 +53,7 @@ try {
     ]);
 } catch (Exception $e) {
     http_response_code(500);
-    echo json_encode(['status' => 'error', 'message' => $e->getMessage()]);
+    error_log("[growth.php] " . $e->getMessage());
+    echo json_encode(['status' => 'error', 'message' => 'An internal error occurred']);
 }
 ?>

backend/Admin/v2/analytics/revenue.php

@@ -47,6 +47,7 @@ try {
     ]);
 } catch (Exception $e) {
     http_response_code(500);
-    echo json_encode(['status' => 'error', 'message' => $e->getMessage()]);
+    error_log("[revenue.php] " . $e->getMessage());
+    echo json_encode(['status' => 'error', 'message' => 'An internal error occurred']);
 }
 ?>

backend/Admin/v2/financial/settlements.php

@@ -39,6 +39,7 @@ try {
     ]);
 } catch (Exception $e) {
     http_response_code(500);
-    echo json_encode(['status' => 'error', 'message' => $e->getMessage()]);
+    error_log("[settlements.php] " . $e->getMessage());
+    echo json_encode(['status' => 'error', 'message' => 'An internal error occurred']);
 }
 ?>

backend/Admin/v2/financial/stats.php

@@ -29,6 +29,7 @@ try {
     ]);
 } catch (Exception $e) {
     http_response_code(500);
-    echo json_encode(['status' => 'error', 'message' => $e->getMessage()]);
+    error_log("[stats.php] " . $e->getMessage());
+    echo json_encode(['status' => 'error', 'message' => 'An internal error occurred']);
 }
 ?>

backend/Admin/v2/quality/blacklist_manager.php

@@ -97,6 +97,7 @@ try {
     jsonError("Invalid action_type", 400);
 
 } catch (Exception $e) {
-    jsonError("Blacklist action failed: " . $e->getMessage(), 500);
+    error_log("[blacklist_manager.php] " . $e->getMessage());
+    jsonError("Blacklist action failed. Please try again later.", 500);
 }
 ?>

backend/Admin/v2/quality/driver_scorecard.php

@@ -100,6 +100,7 @@ try {
     jsonSuccess($scorecard);
 
 } catch (Exception $e) {
-    jsonError("Failed to fetch scorecard: " . $e->getMessage(), 500);
+    error_log("[driver_scorecard.php] " . $e->getMessage());
+    jsonError("Failed to fetch scorecard. Please try again later.", 500);
 }
 ?>

backend/Admin/v2/realtime_dashboard.php

@@ -57,6 +57,7 @@ try {
     echo json_encode($response);
 } catch (Exception $e) {
     http_response_code(500);
-    echo json_encode(['status' => 'error', 'message' => $e->getMessage()]);
+    error_log("[realtime_dashboard.php] " . $e->getMessage());
+    echo json_encode(['status' => 'error', 'message' => 'An internal error occurred']);
 }
 ?>

backend/Admin/v2/smart_alerts.php

@@ -72,6 +72,7 @@ try {
     ]);
 } catch (Exception $e) {
     http_response_code(500);
-    echo json_encode(['status' => 'error', 'message' => $e->getMessage()]);
+    error_log("[smart_alerts.php] " . $e->getMessage());
+    echo json_encode(['status' => 'error', 'message' => 'An internal error occurred']);
 }
 ?>