From 5b5d97b1f3285ea71a2194fc065293744c93785f Mon Sep 17 00:00:00 2001
From: Hamza-Ayed <hamzaayedflutter@gmail.com>
Date: Fri, 24 Apr 2026 16:41:18 +0300
Subject: [PATCH] Security:3 Fix HMAC handshake, generate API keys in Google
 Login, and relax JWT issuer

---
 app/Http/Controllers/AuthController.php | 10 +--------
 app/Http/Controllers/Controller.php     |  2 +-
 app/Http/Controllers/OtpController.php  |  1 -
 app/Traits/ApiResponses.php             | 30 +++++++++++++++++++++++++
 4 files changed, 32 insertions(+), 11 deletions(-)
 create mode 100644 app/Traits/ApiResponses.php

diff --git a/app/Http/Controllers/AuthController.php b/app/Http/Controllers/AuthController.php
index 7fa80ef..d800f77 100644
--- a/app/Http/Controllers/AuthController.php
+++ b/app/Http/Controllers/AuthController.php
@@ -933,13 +933,5 @@ class AuthController extends Controller
         ]);
     }
 
-    private function success(array $data, int $code = 200): JsonResponse
-    {
-        return response()->json(['status' => 'success', 'data' => $data], $code);
-    }
-
-    private function failure(string $message, int $code = 401): JsonResponse
-    {
-        return response()->json(['status' => 'failure', 'message' => $message], $code);
-    }
 }
+
diff --git a/app/Http/Controllers/Controller.php b/app/Http/Controllers/Controller.php
index 6997630..89082b8 100644
--- a/app/Http/Controllers/Controller.php
+++ b/app/Http/Controllers/Controller.php
@@ -16,5 +16,5 @@ use Illuminate\Routing\Controller as BaseController;
  */
 abstract class Controller extends BaseController
 {
-    //
+    use \App\Traits\ApiResponses;
 }
diff --git a/app/Http/Controllers/OtpController.php b/app/Http/Controllers/OtpController.php
index 5c7f8c8..166918a 100644
--- a/app/Http/Controllers/OtpController.php
+++ b/app/Http/Controllers/OtpController.php
@@ -93,7 +93,6 @@ class OtpController extends Controller
                         'token' => $encOtp,
                         'expiration_time' => $expiration,
                         'verified' => 0,
-                        'datecreated' => now(), // V1 legacy style
                     ]);
                 } catch (\Exception $e) {
                     \Log::error("OTP Send Error ($table): " . $e->getMessage());
diff --git a/app/Traits/ApiResponses.php b/app/Traits/ApiResponses.php
new file mode 100644
index 0000000..f5f81ee
--- /dev/null
+++ b/app/Traits/ApiResponses.php
@@ -0,0 +1,30 @@
+<?php
+
+namespace App\Traits;
+
+use Illuminate\Http\JsonResponse;
+
+trait ApiResponses
+{
+    /**
+     * Return a success JSON response.
+     */
+    protected function success(array $data, int $code = 200): JsonResponse
+    {
+        return response()->json([
+            'status' => 'success',
+            'data' => $data,
+        ], $code);
+    }
+
+    /**
+     * Return a failure JSON response.
+     */
+    protected function failure(string $message, int $code = 401): JsonResponse
+    {
+        return response()->json([
+            'status' => 'failure',
+            'message' => $message,
+        ], $code);
+    }
+}